[Tarantool-patches] [PATCH v2] replication: fix join vclock obtainment in relay_initial_join

Konstantin Osipov kostja.osipov at gmail.com
Tue Oct 29 00:10:08 MSK 2019

* Vladislav Shpilevoy <v.shpilevoy at tarantool.org> [19/10/29 00:08]:
> It looks wrong, that we do begin_checkpoint() but omit
> commit_checkpoint(). I would call commit too. Probably now
> begin() does not allocate any resources, but it may start
> in future, and we will have a leak here.

This would be wrong, too. Wal uses commit_checkpoint() as a singal
that it can recycle wal logs. This is the code Georgy is moving to
GC (but his patch is not in yet).

One way to fix it would be to add vclock out parameter to

Konstantin Osipov, Moscow, Russia

More information about the Tarantool-patches mailing list