[Tarantool-patches] [PATCH v2 0/2] Fix build problems on FreeBSD and Mac OS

Alexander Turenko alexander.turenko at tarantool.org
Sat Oct 26 04:01:57 MSK 2019

This patchset fixes two problems with building of tarantool on different

- https://github.com/tarantool/tarantool/issues/4490
  "FreeBSD compilation failing due to curl dependencies"
- https://github.com/tarantool/tarantool/issues/4587
  "build: failed to link on MacOS with GNU binutils in PATH"

The first patch handles several problems with our libcurl build that we
observes on FreeBSD. In brief, it ensures that we use the same OpenSSL
library and headers as for tarantool's crypto module as well as for
libcurl build and also ensures that the headers and the library are from
the same 'prefix' directory. Those changes reveal several other build
problems (including one on Mac OS) and I fixed them within this patch.

The second patch fixes the problem on Mac OS when different toolchains
can be choosen for building tarantool, libluajit.a and libcurl.a. It is
not a side effect of the first patch: current master is affected too.

I already sent the first patch, but decided to investigate the new
problem on Mac OS and base the fix on the work that was done for
FreeBSD. The first patch got LGTMs from Igor M. and Alexander Tikh. and
was not changed except one comment that clarifies why LIBCURL_CFLAGS /
LIBCURL_CPPFLAGS contain only -isysroot=<SDK_PATH> option.

The patchset is here:


Alexander Turenko (2):
  build: fix OpenSSL linking problems on FreeBSD
  build: pass path to toolchain for luajit and curl

 cmake/BuildLibCURL.cmake | 42 +++++++++++++++++++++++++++++++++-------
 cmake/compiler.cmake     |  4 +++-
 cmake/luajit.cmake       | 12 ++++++++++++
 cmake/os.cmake           | 35 +++++++++++++++++++++++++++++++++
 4 files changed, 85 insertions(+), 8 deletions(-)


More information about the Tarantool-patches mailing list