[Tarantool-patches] [tarantool-patches] [PATCH] sql: remove expmask from prepared statement
Nikita Pettik
korablev at tarantool.org
Mon Oct 21 00:46:34 MSK 2019
On 19 Oct 15:33, Vladislav Shpilevoy wrote:
> Hi! Thanks for the patch!
>
> LGTM.
Pushed to master as trivial.
> On 18/10/2019 15:47, Nikita Pettik wrote:
> > expmask indicated necessity to recompile statement after parameter was
> > bound: it might turn out that parameter can affect query plan. However,
> > part of this mechanism has been removed long ago as a SQLite's legacy.
> > In its current state expmask is likely to be useless and assertions
> > involving it are obviously unsuitable. This patch completely removes
> > expmask and related routines.
> >
> > Closes #4566
> > ---
> > Branch: https://github.com/tarantool/tarantool/tree/np/gh-4566-remove-exp-mask
> > Issue: https://github.com/tarantool/tarantool/issues/4566
> >
> > src/box/sql/vdbe.h | 1 -
> > src/box/sql/vdbeInt.h | 1 -
> > src/box/sql/vdbeapi.c | 19 -------------------
> > src/box/sql/vdbeaux.c | 16 ----------------
> > src/box/sql/vdbemem.c | 1 -
> > src/box/sql/whereexpr.c | 2 --
> > test/sql/bind.result | 32 ++++++++++++++++++++++++++++++++
> > test/sql/bind.test.lua | 9 +++++++++
> > 8 files changed, 41 insertions(+), 40 deletions(-)
> >
More information about the Tarantool-patches
mailing list