[tarantool-patches] Re: [PATCH v1] test: FreeBSD is ready for tests with data segment

Igor Munkin imun at tarantool.org
Mon Oct 14 10:55:12 MSK 2019


LGTM.

On 14.10.19, Alexander V. Tikhonov wrote:
> After the issue #4537 fixed for the data segment size limit,
> the temporary blocked tests because of it unblocked.
> 
> Part of #4271
> ---
> 
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4271-restore-tests-after-4537-fixed
> Issue: https://github.com/tarantool/tarantool/issues/4271
> 
>  test/app-tap/debug.skipcond        | 8 --------
>  test/app-tap/minimal.skipcond      | 8 --------
>  test/app-tap/tarantoolctl.skipcond | 8 --------
>  3 files changed, 24 deletions(-)
>  delete mode 100644 test/app-tap/debug.skipcond
>  delete mode 100644 test/app-tap/minimal.skipcond
>  delete mode 100644 test/app-tap/tarantoolctl.skipcond
> 
> diff --git a/test/app-tap/debug.skipcond b/test/app-tap/debug.skipcond
> deleted file mode 100644
> index 7950a5d93..000000000
> --- a/test/app-tap/debug.skipcond
> +++ /dev/null
> @@ -1,8 +0,0 @@
> -import platform
> -
> -# Disabled on FreeBSD due to fail #4271:
> -#   Data segment size exceeds process limit
> -if platform.system() == 'FreeBSD':
> -    self.skip = 1
> -
> -# vim: set ft=python:
> diff --git a/test/app-tap/minimal.skipcond b/test/app-tap/minimal.skipcond
> deleted file mode 100644
> index 7950a5d93..000000000
> --- a/test/app-tap/minimal.skipcond
> +++ /dev/null
> @@ -1,8 +0,0 @@
> -import platform
> -
> -# Disabled on FreeBSD due to fail #4271:
> -#   Data segment size exceeds process limit
> -if platform.system() == 'FreeBSD':
> -    self.skip = 1
> -
> -# vim: set ft=python:
> diff --git a/test/app-tap/tarantoolctl.skipcond b/test/app-tap/tarantoolctl.skipcond
> deleted file mode 100644
> index 7950a5d93..000000000
> --- a/test/app-tap/tarantoolctl.skipcond
> +++ /dev/null
> @@ -1,8 +0,0 @@
> -import platform
> -
> -# Disabled on FreeBSD due to fail #4271:
> -#   Data segment size exceeds process limit
> -if platform.system() == 'FreeBSD':
> -    self.skip = 1
> -
> -# vim: set ft=python:
> -- 
> 2.17.1
> 

-- 
Best regards,
IM




More information about the Tarantool-patches mailing list