[Tarantool-patches] [tarantool-patches] [PATCH v1 0/5] Replace control pragmas by SET

[Vladislav Shpilevoy]

Hi! Thanks for the patchset!

Mostly the design is ok. Consider a question below.

What about having a more general settings space? For all
session settings. Named like '_vsession_settings'. Or
'_vsession_storage'. It will be exactly like in your
patchset, but all SQL settings will have 'sql_' prefix.
And then we could reuse that space for other settings,
even from not SQL, like Kostja planned.

I am just afraid, that number of system spaces grows
without a control. With current pace we have only 16
free IDs left for system spaces. Next are user space.
See, now we've used 380. The last is 511. Interval is 8.
131 / 8 = 16. And we can't put them tighter. We
need 8-width gaps to be able to insert new spaces
between existing ones when a certain recovery order will
be needed.

16 is not really many, taking into account a pile of
information schema views going to be added.

On 17/10/2019 16:40, imeevma at tarantool.org wrote:
> This patch0set created a new SQL command: SET. This command is
> used to change SQL settings, including debugging settings.
> 
> The main goal of this fix pack version is to choose a design to
> solve the problem.
> 
> https://github.com/tarantool/tarantool/issues/4511
> https://github.com/tarantool/tarantool/tree/imeevma/gh-4511-pragma-replaced-by-set
>