[Tarantool-patches] [tarantool-patches] Re: [PATCH 1/1] replication: auto reconnect if password is invalid

[Vladislav Shpilevoy]

Kostja, thanks for the review!

Kirill, your turn.

On 18/10/2019 00:28, Konstantin Osipov wrote:
> * Vladislav Shpilevoy <v.shpilevoy at tarantool.org> [19/10/18 00:13]:
>> Before the patch there was a race in replication
>> password configuration. It was possible that a replica
>> connects to a master with a custom password before
>> that password is actually set. The replica treated the
>> error as critical and exited.
>>
>> But in fact it is not critical. Replica even can
>> withstand absence of a user and keeps reconnecting.
>> Wrong password situation arises from the same problem
>> of non atomic configuration and is fixed the same -
>> keep reconnect attempts if the password was wrong.
>>
>> Closes #4550
> 
> lgtm
>