[Tarantool-patches] [tarantool-patches] Re: [PATCH 1/1] console: fix usage of an undeclared variable

Cyrill Gorcunov gorcunov at gmail.com
Fri Oct 18 00:08:20 MSK 2019


On Fri, Oct 18, 2019 at 12:05:05AM +0300, Cyrill Gorcunov wrote:
> On Thu, Oct 17, 2019 at 10:31:00PM +0200, Vladislav Shpilevoy wrote:
> > > 
> > > We're reading from a socket and there could be EOF, which will
> > > give us zero return code. But now we will start to yielding
> > > an error in this case.
> > > 
> > 
> > set_error is aware of that. It says 'Peer closed' on EOF.
> 
> Looks reasonable enough. Thanks!

Still (if only I'm not missing something obvious) this changes
api a bit -- previously we've been returning empty string for
this case but now we will print 'Peer closed', hopefully this
won't be a problem though.

	Cyrill


More information about the Tarantool-patches mailing list