[Tarantool-patches] [tarantool-patches] Re: [PATCH v4 3/4] box: do not evaluate ck constraints on recovery

[Nikita Pettik]

On 17 Oct 18:18, Konstantin Osipov wrote:
> * Nikita Pettik <korablev at tarantool.org> [19/10/17 17:41]:
> > Em, I don't see any pros of duplicating global state by passing it
> > as a parameter to functions. Meanwile using local version of force_recovery
> > may turn out to be confusing (at least for developers looking into code).
> 
> Historically xlog.force_recovery is not the same as global
> force_recovery. The logic is a bit more tricky. There used to be
> panic_on_wal_error and panic_on_snap_error, and traces of it are
> still in place.

Ok, then I mean "refactor all places where global is_force_recover is the
same as argument force_recovery".