[Tarantool-patches] [PATCH v1 2/9] box: rename struct trigger to lua_trigger

[Konstantin Osipov]

* Kirill Shcherbatov <kshcherbatov at tarantool.org> [19/10/14 19:06]:
> Renamed struct trigger to struct lua_trigger because the 'trigger'
> name is too general. Currently Tarantool has non-persistent
> AppServer Lua triggers represented with 'trigger' structure so as
> SQL-specific persistent trigger object named 'sql_trigger'.
> 
> In scope of this patchset we going to significantly rework
> triggers subsystem and introduce a new base trigger class named
> 'trigger', so this name is be better to be released.

this is actually quite unfortunate, the trigger name is general
because it is any kind of trigger, it is not only used in Lua.

Just look at the scope of your patch, it's tree-wide.

I think the old name was good.

Besides, renaming the structure without renaming all of the api to
match is faux pas.
> -#include "trigger.h"
> +#include "lib/core/trigger.h"

-- 
Konstantin Osipov, Moscow, Russia