[tarantool-patches] Re: [PATCH v2 3/8] json: lexer_eof and token_cmp helper functions

[Konstantin Osipov]

* Vladislav Shpilevoy <v.shpilevoy at tarantool.org> [19/09/28 09:11]:
> >>  /**
> >> - * Compare JSON token keys.
> >> + * Compare JSON tokens as nodes of a JSON tree. That is, including
> >> + * parent references.
> >>   */
> > 
> > Please explain how it is useful. Why not json_tree_node_cmp then?
> 
> What is useful? Being able to compare two JSON nodes? Not sure if I
> understand the question. I just need to compare two nodes. In several
> places. And I added a function for that.

How it is independently useful , given there still exists the old cmp function.
You added a (yet) another cmp function, the comment should contain
the usage scenario for it.

-- 
Konstantin Osipov, Moscow, Russia