[tarantool-patches] Re: [PATCH 1/1] Deprecate box.cfg.rows_per_wal option

[Alexander Turenko]

On Tue, Sep 10, 2019 at 10:25:05PM +0200, Vladislav Shpilevoy wrote:
> It is deprecated since 1.10 version and is dropped in 2.3.

Changed description a bit (hope you don't mind):

 | test: remove box.cfg.rows_per_wal option
 |
 | It is deprecated since 1.10 version and should be dropped in 2.3 in the
 | scope of https://github.com/tarantool/tarantool/issues/3762

Replaced slab_alloc_arena with memtx_memory in a separate commit
(pushed to the same branch on top of your's one).

Rebased on top of current master.

I'll wait for CI to ensure that everything is fine and will push both
patches to master (tomorrow or so).

> ---
> Branch: https://github.com/tarantool/tarantool-python/tree/gerold103/deprecate-rows-per-wal
> Issue: https://github.com/tarantool/tarantool/issues/3762
> 
>  unit/suites/box.lua                 | 1 -
>  unit/suites/lib/tarantool_server.py | 3 +--
>  2 files changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/unit/suites/box.lua b/unit/suites/box.lua
> index f7c15ed..5f58d68 100644
> --- a/unit/suites/box.lua
> +++ b/unit/suites/box.lua
> @@ -6,5 +6,4 @@ box.cfg{
>      listen           = os.getenv("PRIMARY_PORT"),
>      slab_alloc_arena = 0.1,
>      pid_file         = "box.pid",
> -    rows_per_wal     = 50
>  }
> diff --git a/unit/suites/lib/tarantool_server.py b/unit/suites/lib/tarantool_server.py
> index 291914d..f127171 100644
> --- a/unit/suites/lib/tarantool_server.py
> +++ b/unit/suites/lib/tarantool_server.py
> @@ -46,8 +46,7 @@ class TarantoolServer(object):
>      default_cfg = {
>              "custom_proc_title": "\"tarantool-python testing\"",
>              "slab_alloc_arena":                             0.5,
> -            "pid_file":                           "\"box.pid\"",
> -            "rows_per_wal":                                 200}
> +            "pid_file":                           "\"box.pid\""}
>  
>      @property
>      def logfile_path(self):
> -- 
> 2.20.1 (Apple Git-117)
>