[Tarantool-patches] [PATCH 2/5] lua/fio: Add lbox_fio_push_error as a separate helper

Konstantin Osipov kostja.osipov at gmail.com
Fri Nov 29 09:02:21 MSK 2019


* Cyrill Gorcunov <gorcunov at gmail.com> [19/11/28 23:46]:
> Since lbox_fio_pushbool always push boolean first
> it is inpossible to use it inside other routines.
> Thus make a separate helper lbox_fio_push_error
> which will be used in popen code later.
> 

OK, now I get why you simply use write() in popen API - you
always wrap all calls to popen with a eio call. But why?

Isn't it sufficient to only wrap vfork, everything else 
can be done in the main thread, what do you think?


-- 
Konstantin Osipov, Moscow, Russia


More information about the Tarantool-patches mailing list