[Tarantool-patches] [PATCH 5/6] sql: extend result set with autoincrement

[Vladislav Shpilevoy]

Thanks for the patch!

On 27/11/2019 13:15, Nikita Pettik wrote:
> If result set contains column which features attached sequence
> (AUTOINCREMENT in terms of SQL) then meta-information will contain
> corresponding field ('autoicrement' : boolean) in response.

1. Please, lets name all booleans values with 'is_' prefix:
is_autoincrement, IPROTO_FIELD_IS_AUTOINCREMENT.

> diff --git a/src/box/sql/vdbeInt.h b/src/box/sql/vdbeInt.h
> index 0e54e42a5..63afb8777 100644
> --- a/src/box/sql/vdbeInt.h
> +++ b/src/box/sql/vdbeInt.h
> @@ -355,6 +355,8 @@ struct sql_column_metadata {
>  	 * columns: all other expressions are nullable by default.
>  	 */
>  	int8_t nullable : 2;
> +	/** True if column features autoincrement property. */
> +	int8_t actoincrement : 1;

2. Lets make it bool, and name is_autoincrement.

>  };
>  
>  /*