[Tarantool-patches] [PATCH] Move txn from shema to a separate module (use C API instead of FFI)

Konstantin Osipov kostja.osipov at gmail.com
Thu Nov 28 15:34:45 MSK 2019


* Leonid Vasiliev <lvasiliev at tarantool.org> [19/11/28 11:10]:
> 4) About converts others txn functions from FFI to C-API:
> I think it's a good practice, use one or the other (FFI or C-API) in module

My complaint is about this part. Jit trace can go through FFI but
can't go through Lua/C. This is why many of these functions were
in FFI in the first place. 

We could make a conscious choice to make all box API Lua/C - but
this will literally kill JIT, so then why not just move to
plain Lua 5.3 and forget about grievances with LuaJIT altogether.

Nick Zavaritsky had a patch that would detect sandwich stacks in
runtime and assert. Nobody had time to look at it back then -
everyone was busy with vinyl and sql.

Why not dig it up to protect from future erosion of the code base? 

This would be more valuable contribution than just falling back to
Lua/C for everything.

-- 
Konstantin Osipov, Moscow, Russia


More information about the Tarantool-patches mailing list