[Tarantool-patches] [PATCH v5 7/8] refactoring: remove redundant line in txn_alter_trigger_new

Sergey Ostanevich sergos at tarantool.org
Wed Nov 27 18:00:33 MSK 2019


Hi!

LGTM, thanks!

Sergos

On 22 Nov 05:46, Ilya Kosarev wrote:
> Since refactoring: clear privilege managing triggers from exceptions
> (977fca292ee97e82c6729d4b62a178ee8835af59) we are doing zero memset for
> trigger struct in txn_alter_trigger_new. This means we don't any more
> need to set any field of this struct to NULL explicitly.
> 
> Part of #4247
> ---
>  src/box/alter.cc | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/src/box/alter.cc b/src/box/alter.cc
> index 684b93798..a3a9a5ff9 100644
> --- a/src/box/alter.cc
> +++ b/src/box/alter.cc
> @@ -816,7 +816,6 @@ txn_alter_trigger_new(trigger_f run, void *data)
>  	trigger = (struct trigger *)memset(trigger, 0, size);
>  	trigger->run = run;
>  	trigger->data = data;
> -	trigger->destroy = NULL;
>  	return trigger;
>  }
>  
> -- 
> 2.17.1
> 


More information about the Tarantool-patches mailing list