[Tarantool-patches] [PATCH v5 6/8] refactoring: update comment for index_def_check_tuple

Sergey Ostanevich sergos at tarantool.org
Wed Nov 27 17:59:56 MSK 2019


Hi!

LGTM.

Sergos

On 22 Nov 05:46, Ilya Kosarev wrote:
> Originally index_def_check_tuple comment said that it throws a nice
> error. Since refactoring: remove exceptions from
> index_def_new_from_tuple (90ac0037f6cae587d8ca589dbe45c58e67f05657)
> it returns an error. Now it is clearly specified in the comment.
> 
> Part of #4247
> ---
>  src/box/alter.cc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/box/alter.cc b/src/box/alter.cc
> index 4b3bbca31..684b93798 100644
> --- a/src/box/alter.cc
> +++ b/src/box/alter.cc
> @@ -159,7 +159,7 @@ index_def_check_sequence(struct index_def *index_def, uint32_t sequence_fieldno,
>  
>  /**
>   * Support function for index_def_new_from_tuple(..)
> - * Checks tuple (of _index space) and sets a nice diag if it is invalid
> + * Checks tuple (of _index space) and returns an error if it is invalid
>   * Checks only types of fields and their count!
>   */
>  static int
> -- 
> 2.17.1
> 


More information about the Tarantool-patches mailing list