[Tarantool-patches] [PATCH] Move txn from shema to a separate module (use C API instead of FFI)

[Konstantin Osipov]

* Alexander Turenko <alexander.turenko at tarantool.org> [19/11/27 00:17]:
> > > https://github.com/tarantool/tarantool/issues/4427
> > 
> > > https://github.com/tarantool/tarantool/tree/lvasiliev/gh-4427-move-some-stuff-from-ffi-to-c-api
> > 
> > Please add a test case. And an explanation of how the fix solves
> > the issue. The patch is an overkill - the trace is going through
> > box_txn_rollback_to_savepoint, so moving it off ffi to C api
> > should be sufficient.
> 
> I would add a bit more context here. The original patch was made by
> Sergey O. and I asked for extracting all related functions into its own
> 'module'. See links below.
> 
> https://lists.tarantool.org/pipermail/tarantool-patches/2019-September/006747.html
> https://lists.tarantool.org/pipermail/tarantool-patches/2019-September/000734.html
> 
> The moving of just one function should be sufficient, you're right.
> However it is not much more work then extracting all those related
> function into tnx.{c,h,lua}. So I think it worth to do just here.
> 
> Are you agree that box/lua/txn.* is more proper place for those
> functions then box/lua/schema.lua?

The move also converts these functions from ffi to plain C. 
This is what I am objecting against.

-- 
Konstantin Osipov, Moscow, Russia