[Tarantool-patches] [PATCH] test: adjust the test name related to PAIRSMM flag

Igor Munkin imun at tarantool.org
Wed Nov 27 00:32:16 MSK 2019


Kostja,

Thanks for your remark. I've seen no mention related to the test naming
in our contribution guide[1]. However, your point is valid: *all* other
chunks uses underscores, but not dashes, and the name used in this patch
differs from already existing ones.

Besides, there is another convention mentioned by Vlad and successfully
missed by me sometime.

I see the most convenient solution is adjusting the related test name to
a common style and further naming refactoring within some follow-up
activity.

On 26.11.19, Konstantin Osipov wrote:
> * Alexander Turenko <alexander.turenko at tarantool.org> [19/11/26 19:57]:
> > > rename from test/mmpairs_test.lua
> > > rename to test/mmpairs-tarantool-4560.test.lua
> 
> *All* of the source code uses underscores, not dashes for file
> names. 
> 
> 
> -- 
> Konstantin Osipov, Moscow, Russia

[1]: https://www.tarantool.io/en/doc/2.2/dev_guide/lua_style_guide/#testing

-- 
Best regards,
IM


More information about the Tarantool-patches mailing list