[Tarantool-patches] [PATCH] box: frommap() bug fix
Chris Sosnin
k.sosnin at tarantool.org
Mon Nov 25 00:18:55 MSK 2019
- If an optional argument is provided for
space_object:frommap() (which is {table = true|false}),
type match for first arguments is omitted, which is
incorrect. We should return the result only after making
sure it is possible to build a tuple.
- If there is a type mismatch, however, frommap() does not
return nil, err as it is mentioned in the description, so we
change it to be this way.
Closes: #4262
---
src/box/lua/space.cc | 11 +++++++----
test/box/tuple.result | 3 ++-
2 files changed, 9 insertions(+), 5 deletions(-)
diff --git a/src/box/lua/space.cc b/src/box/lua/space.cc
index f6e96f0c0..a4ffa8240 100644
--- a/src/box/lua/space.cc
+++ b/src/box/lua/space.cc
@@ -580,14 +580,17 @@ lbox_space_frommap(struct lua_State *L)
}
lua_rawseti(L, -3, fieldno+1);
}
- if (table)
- return 1;
lua_replace(L, 1);
lua_settop(L, 1);
tuple = luaT_tuple_new(L, -1, space->format);
- if (tuple == NULL)
- return luaT_error(L);
+ if (tuple == NULL) {
+ struct error *e = diag_last_error(&fiber()->diag);
+ lua_pushnil(L);
+ lua_pushstring(L, e->errmsg);
+ return 2;
+ } else if (table)
+ return 1;
luaT_pushtuple(L, tuple);
return 1;
usage_error:
diff --git a/test/box/tuple.result b/test/box/tuple.result
index 9140211b7..bbb60d5e7 100644
--- a/test/box/tuple.result
+++ b/test/box/tuple.result
@@ -1121,7 +1121,8 @@ s:frommap()
...
s:frommap({})
---
-- error: Tuple field 1 required by space format is missing
+- null
+- Tuple field 1 required by space format is missing
...
s:frommap({ddd = 1, aaa = 2, ccc = 3, bbb = 4}, {table = true})
---
--
2.24.0
More information about the Tarantool-patches
mailing list