[Tarantool-patches] [PATCH 1/1] func: fix use after free on function unload

Kirill Yukhin kyukhin at tarantool.org
Thu Nov 21 20:30:00 MSK 2019


Hello,

On 06 ноя 16:12, Vladislav Shpilevoy wrote:
> Functions are stored in lists inside module objects. Module
> objects are stored in a hash table, where key is a package name.
> But the key was a pointer at one of module's function definition
> object. Therefore, when that function was deleted, its freed
> package name memory was still in the hash key, and could be
> accessed, when another function was deleted.
> 
> Now module does not use memory of its functions, and keep a copy
> of the package name.
> ---
> Branch: https://github.com/tarantool/tarantool/tree/gerold103/func-unload-use-after-free
> No issue.

The patch LGTM. I've checked it into 1.10, 2.2 and master.

--
Regards, Kirill Yukhin


More information about the Tarantool-patches mailing list