[Tarantool-patches] [PATCH v3 0/3] fiber.top(): minor fixup
Vladislav Shpilevoy
v.shpilevoy at tarantool.org
Wed Nov 20 01:57:11 MSK 2019
Hi! Thanks for the fixes!
LGTM.
On 18/11/2019 17:05, Serge Petrenko wrote:
> The first patch factors all the clock-related members of struct fiber and struct
> cord into appropriate structs and adds methods for their updates and resets.
>
> The second patch fixes exponential moving average calculation so that we do not
> experience huge numbers in average load percentage calculations.
>
> The third patch alters fiber.top() test to wait for correct output before
> testing it.
>
> Follow-up https://github.com/tarantool/tarantool/issues/2694
> Branch https://github.com/tarantool/tarantool/tree/sp/gh-2694-test-fixup
>
> Changes in v3:
> - introduce a new patch which refactors all the clock stat
> handling.
> - introduce a patch fixing EMA calculation
> - review fixes as per review from Vladislav
>
> Changes in v2:
> - clean up all fibers clock stats on fiber.top_enable()
> - push 0 instead of NaN when cord clock_delta_last is 0
> - review fixes as per review from Vladislav
>
> Serge Petrenko (3):
> fiber.top() refactor clock and cpu time calculation
> fiber.top(): alter exponential moving average calculation
> app/fiber: wait till a full event loop iteration ends
>
> src/lib/core/fiber.c | 175 ++++++++++++++++++++++++----------------
> src/lib/core/fiber.h | 109 +++++++++++++++++--------
> src/lua/fiber.c | 20 +++--
> test/app/fiber.result | 38 ++++++---
> test/app/fiber.test.lua | 36 +++++++--
> 5 files changed, 252 insertions(+), 126 deletions(-)
>
More information about the Tarantool-patches
mailing list