[Tarantool-patches] [PATCH v2 1/1] iproto: don't destroy a session during disconnect

Konstantin Osipov kostja.osipov at gmail.com
Sat Nov 16 16:07:40 MSK 2019


* Vladislav Shpilevoy <v.shpilevoy at tarantool.org> [19/11/16 12:48]:
> Binary session disconnect trigger yield could lead to use after
> free of the session object. That happened because iproto thread
> sent two requests to TX thread at disconnect:

LGTM, except that I usually try to avoid duplicating state, so
do_destroy_on_close looks a bit superfluous, especially since you
have another variable - is_destroy_sent.

>  	/** True if destroy message is sent. Debug-only. */
>  	bool is_destroy_sent;


-- 
Konstantin Osipov, Moscow, Russia


More information about the Tarantool-patches mailing list