[Tarantool-patches] [PATCH] json: fix assert typo in json_path_cmp()

Nikita Pettik korablev at tarantool.org
Mon Nov 11 18:06:32 MSK 2019


   284  int
   285  json_path_cmp(const char *a, int a_len, const char *b, int b_len,
   286                int index_base)
   287  {

  ...

   304          /* Paths a and b must be valid. */
   305          assert(rc_b == 0 && rc_b == 0);

Obviously (according to the comment) author implied that both rc_a == 0
and rc_b == 0. Let's fix this small typo.
---
Branch: https://github.com/tarantool/tarantool/tree/np/json-assert-typo

 src/lib/json/json.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/lib/json/json.c b/src/lib/json/json.c
index 1bfef172a..ffac2c2b5 100644
--- a/src/lib/json/json.c
+++ b/src/lib/json/json.c
@@ -302,7 +302,7 @@ json_path_cmp(const char *a, int a_len, const char *b, int b_len,
 			return rc;
 	}
 	/* Paths a and b must be valid. */
-	assert(rc_b == 0 && rc_b == 0);
+	assert(rc_a == 0 && rc_b == 0);
 	/*
 	 * The parser stopped because the end of one of the paths
 	 * was reached. As JSON_TOKEN_END > JSON_TOKEN_{NUM, STR},
-- 
2.15.1



More information about the Tarantool-patches mailing list