[Tarantool-patches] [PATCH v2] build: enable CentOS 8 packaging

[Alexander Turenko]

On Fri, Nov 08, 2019 at 07:20:09PM +0300, Igor Munkin wrote:
> Sasha Ti. and Sasha Tu.,
> 
> Thanks, though I left some minor comments below the polished patch is
> totally LGTM.
> 
> Sasha Tu., feel free to proceed.

Thanks for review!

Pushed to master, 2.2, 2.1 and 1.10.

CCed Kirill.

> > My variant of the commit message is below. Please, let me know whether
> > you are okay with it. I left all points you highlighted and tried to
> > make its description more easy to understand w/o much context.
> > 
> >  | travis-ci/gitlab-ci: add CentOS 8
> 
> Minor: build label seems to be more suitable for this changeset.

Okay. Changed to 'build: add CentOS 8 into CI / CD'.

> >  | Eliminated libunwind runtime dependency (and libunwind-devel build
> >  | dependency) on CentOS 8, because the base system does not provide it.
> >  | fiber.info() backtraces and printing of a backtrace after a crash will
> >  | not be available on this system. Hopefully we'll fix it in the future,
> >  | filed #4611 on this.

> Minor: feel free to mention a co-author here cause you both made a huge
> work on this issue.

Don't sure how to differentiate situations when I should add
'Reviewed-by' and when 'Co-developed-by'. Added the former, because my
changes were made in response to Alexander's request to review his
patch.