[Tarantool-patches] [PATCH 3/3] sql: make type string case lower everywhere

Nikita Pettik korablev at tarantool.org
Thu Nov 7 15:40:28 MSK 2019


On 28 Oct 22:45, Vladislav Shpilevoy wrote:
> Thanks for the review!
> 
> On 28/10/2019 15:23, Nikita Pettik wrote:
> > On 27 Oct 22:35, Vladislav Shpilevoy wrote:
> >> Type was displayed in error messages, was returned in
> >> meta headers, and a type string is a result of
> >> typeof() SQL function.
> >>
> >> Typeof() always returns lower case type string; meta
> >> contained upper case type; error messages contained
> >> both.
> >>
> >> It was necessary to choose one case for everything,
> >> and the lower one was chosen. It allows not to break
> >> typeof() function which actually might be used by
> >> someone.
> >>
> >> Part of #4462
> > 
> > CI status is negative: sql/bind.test.lua fails. Please, update result file.
> 
> Fixed.
> 
> > The rest is OK as trivial. I want Kirill to look at this change and give
> > explicit ack for this change. In the latter case, it can be pushed out of order.
> >

Pushed to master.
 


More information about the Tarantool-patches mailing list