[Tarantool-patches] [PATCH 1/1] replication: use empty password by default

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Tue Nov 5 15:51:32 MSK 2019


Also I forgot a description for the test.
Here it is: (force pushed to the branch)

========================================================================

diff --git a/test/replication/gh-4605-empty-password.result b/test/replication/gh-4605-empty-password.result
index 4cb2c37c1..defdfcfcd 100644
--- a/test/replication/gh-4605-empty-password.result
+++ b/test/replication/gh-4605-empty-password.result
@@ -2,6 +2,16 @@
 test_run = require('test_run').new()
  | ---
  | ...
+
+--
+-- gh-4605: replication and netbox both use URI as a remote
+-- resource identifier. If URI does not contain a password, netbox
+-- assumes it is an empty string - ''. But replication's applier
+-- wasn't assuming the same, and just didn't send a password at
+-- all, when it was not specified in the URI. It led to a strange
+-- error message and inconsistent behaviour. The test checks, that
+-- replication now also uses an empty string password by default.
+
 box.schema.user.create('test_user', {password = ''})
  | ---
  | ...
diff --git a/test/replication/gh-4605-empty-password.test.lua b/test/replication/gh-4605-empty-password.test.lua
index 5472b66cd..f42a55f81 100644
--- a/test/replication/gh-4605-empty-password.test.lua
+++ b/test/replication/gh-4605-empty-password.test.lua
@@ -1,4 +1,14 @@
 test_run = require('test_run').new()
+
+--
+-- gh-4605: replication and netbox both use URI as a remote
+-- resource identifier. If URI does not contain a password, netbox
+-- assumes it is an empty string - ''. But replication's applier
+-- wasn't assuming the same, and just didn't send a password at
+-- all, when it was not specified in the URI. It led to a strange
+-- error message and inconsistent behaviour. The test checks, that
+-- replication now also uses an empty string password by default.
+
 box.schema.user.create('test_user', {password = ''})
 box.schema.user.grant('test_user', 'replication')
 
========================================================================


More information about the Tarantool-patches mailing list