[Tarantool-patches] [PATCH 2/3] user: don't throw C++ exception from user_find_by_name

[Konstantin Osipov]

* Vladislav Shpilevoy <v.shpilevoy at tarantool.org> [19/11/01 00:39]:
> +-- Invalid user.
> +session.su('does not exist')
> +---
> +- error: User 'does not exist' is not found
> +...
> +-- The point of this test is to try a name > max
> +-- allowed name.
> +session.su(string.rep('a', 66000))
> +---
> +- error: name length 66000 is greater than BOX_NAME_MAX
> +...

That's pretty strange, I think we had such tests before.

Did you actually verify that the tests do not pass before your
fix? Or they do pass because there is a catch clause somewhere
up the stack anyway?

Please clarify in the comment.

Otherwise LGTM.


-- 
Konstantin Osipov, Moscow, Russia