[Tarantool-patches] [tarantool-patches] Re: [PATCH v2 2/2] say: take getaddrinfo() errors into account

[Alexander Turenko]

> coiox/say: fix getaddrinfo error handling on macOS

Typo: coiox -> coio.

> >>>> +	isnt(strstr(diag_get()->last->errmsg, "getaddrinfo"), NULL,
> >>>> +	     "getaddrinfo error message");
> >>>> +
> >>> 
> >>> I propose to verify the entire error message using
> >>> gai_strerror(GAI_AGAIN) and gai_strerror(GAI_NONAME)—just as proposed
> >>> above for a log message.
> >> I have not found the way, how to carry this macros/enum from the libc header to Lua.
> > 
> > It is possible to add them into socket.c, but anyway it is not worth to
> > do this just for a test. Let's check for certain error messages (not for
> > just 'getaddrinfo: ' prefix).

Again: let's check for certain error messages (not for just
'getaddrinfo: ' prefix).

The patch looks okay other then this.