[PATCH] core/coio_file: copyfile -- Make it behave as regular cp

Cyrill Gorcunov gorcunov at gmail.com
Mon May 6 11:43:38 MSK 2019


On Mon, May 06, 2019 at 11:37:29AM +0300, Vladimir Davydov wrote:
> > 
> > Also I just wondered that most of tests in test/app/fio.test.lua
> > do pass octal modes as 0777 while lua's number parser simply doesn't
> > understand octal form. So that I had to pass mode 420 by hands which
> > is an alias to 0644.
> 
> I guess we should change 0644 to tonumber('644', 8) across the whole
> test suite. Could you please do it in a separate patch?

Will do.

> Anyway, the new test case passes both with and without this patch, which
> means it's useless. Please make sure it fails without the changes made
> to the code by this patch.

OK



More information about the Tarantool-patches mailing list