[tarantool-patches] Re: [PATCH v5 4/6] schema: add new system space for CHECK constraints

[n.pettik]

>> diff --git a/src/box/sql/parse.y b/src/box/sql/parse.y
>> index f241b8d52..e93dfe751 100644
>> --- a/src/box/sql/parse.y
>> +++ b/src/box/sql/parse.y
>> @@ -297,7 +297,7 @@ ccons ::= check_constraint_def .
>> 
>> check_constraint_def ::= cconsname(N) CHECK LP expr(X) RP. {
>>   create_ck_def_init(&pParse->create_ck_def, &N, &X);
>> -  sql_add_check_constraint(pParse);
>> +  sql_create_check_contraint(pParse);
> 
> 9. What was a motivation of this rename? As I understand,
> we can add many CHECK constraints in one CREATE TABLE. We
> do not 'create' one single CHECK, we add multiple ones. Please,
> keep the old name.

It was me who asked for this refactoring. We already have
sql_create_foreign_key() and sql_create_index(), so my
intention was to keep naming consistent.