[tarantool-patches] [PATCH v2 0/9] sql: cleanup code from obsolete macros

Stanislav Zudin szudin at tarantool.org
Wed May 29 17:01:22 MSK 2019


The patch removes unused constants and macros
The 2nd version returns back the SQL_OMIT_AUTOMATIC_INDEX and
the code enabled by this macro.
Removes the remains of the multithreading from the VDBE's 
sorting tools.
Enables output of number of scanned rows when EXPLAIN
keyword is used. Updates the affected tests.


Issue: https://github.com/tarantool/tarantool/issues/3978
Branch: https://github.com/tarantool/tarantool/tree/stanztt/gh-3978-obsolete-macros

Stanislav Zudin (9):
  sql: cleanup code from obsolete macros
  Removes unused functions and commented many years ago code.
  Removes unused functions.
  Removes unused functions and macros.
  Removes the following unused macros: SQL_ENABLE_MEMORY_MANAGEMENT
    SQL_ENABLE_UNKNOWN_SQL_FUNCTION SQL_SUBSTR_COMPATIBILITY
    SQL_ENABLE_STMT_SCANSTATUS
  sql: cleanup code from obsolete macros
  Removes unused constants
  Removes the following unused macros: SQL_PRINTF_PRECISION_LIMIT
    SQL_OMIT_COMPOUND_SELECT SQL_POWERSAFE_OVERWRITE
    SQL_OMIT_PROGRESS_CALLBACK SQL_OMIT_AUTORESET SQL_OMIT_DECLTYPE
    SQL_ENABLE_COLUMN_METADATA SQL_TRACE_SIZE_LIMIT
    SQL_OMIT_LIKE_OPTIMIZATION SQL_OMIT_OR_OPTIMIZATION
    SQL_OMIT_BETWEEN_OPTIMIZATION
  sql: cleanup code from obsolete macros

 extra/mkkeywordhash.c                    |  24 -
 src/box/sql/CMakeLists.txt               |   1 -
 src/box/sql/build.c                      |   3 -
 src/box/sql/cursor.h                     |  25 -
 src/box/sql/date.c                       |   8 +-
 src/box/sql/expr.c                       |  94 +--
 src/box/sql/fault.c                      |   3 -
 src/box/sql/func.c                       |  30 -
 src/box/sql/global.c                     |   6 -
 src/box/sql/hwtime.h                     |  63 --
 src/box/sql/insert.c                     |   4 -
 src/box/sql/main.c                       |  79 ---
 src/box/sql/malloc.c                     | 170 -----
 src/box/sql/os_unix.c                    |   2 -
 src/box/sql/parse.y                      |  12 +-
 src/box/sql/printf.c                     |  10 -
 src/box/sql/random.c                     |  26 -
 src/box/sql/resolve.c                    |   6 +-
 src/box/sql/select.c                     |  33 +-
 src/box/sql/sqlInt.h                     | 273 +-------
 src/box/sql/treeview.c                   |   4 +-
 src/box/sql/trigger.c                    |   2 -
 src/box/sql/util.c                       | 106 ---
 src/box/sql/vdbe.c                       |  47 +-
 src/box/sql/vdbe.h                       |  15 +-
 src/box/sql/vdbeInt.h                    |  10 -
 src/box/sql/vdbeapi.c                    | 151 +----
 src/box/sql/vdbeaux.c                    |  83 ---
 src/box/sql/vdbesort.c                   | 800 +++--------------------
 src/box/sql/vdbetrace.c                  |  34 -
 src/box/sql/where.c                      |  41 +-
 src/box/sql/whereInt.h                   |  12 -
 src/box/sql/wherecode.c                  |  61 +-
 src/box/sql/whereexpr.c                  |  11 +-
 test/sql-tap/collation.test.lua          |   6 +-
 test/sql-tap/eqp.test.lua                | 246 +++----
 test/sql-tap/gh-2996-indexed-by.test.lua |  12 +-
 test/sql-tap/index6.test.lua             |   4 +-
 test/sql-tap/index7.test.lua             |   2 +-
 test/sql-tap/lua-tables.test.lua         |   4 +-
 test/sql-tap/tkt-385a5b56b9.test.lua     |  26 +-
 test/sql-tap/tkt-b75a9ca6b0.test.lua     |   4 +-
 test/sql-tap/tkt3442.test.lua            |   4 +-
 test/sql-tap/where3.test.lua             |   6 +-
 test/sql-tap/whereG.test.lua             |  16 +-
 test/sql/row-count.result                |   2 +-
 46 files changed, 313 insertions(+), 2268 deletions(-)

-- 
2.17.1





More information about the Tarantool-patches mailing list