[tarantool-patches] Re: [PATCH v1 2/3] schema: extend _func space to persist lua functions

Konstantin Osipov kostja at tarantool.org
Fri May 17 18:29:52 MSK 2019


* Kirill Shcherbatov <kshcherbatov at tarantool.org> [19/05/17 15:37]:
> > While we are at it, I would also add 'type' - function or
> > procedure, and other related to SQL procedures fields.
> > 
> > See for example here:
> > 
> > https://mariadb.com/kb/en/library/mysqlproc-table/
> > (not all of these fields are relevant, and perhaps we need an
> > 'options' map, to make the whole thing easily extensible in the
> > future, but it's better to put as many fields as possible into
> > columns, not options).
> 
> Thank you for this reference.
> I think we'll need 'is_deterministic' flag soon enough (in scope of
> functional indexes), so I've introduced it.
> To make the process of introducing such options extensible,
> @locker and I decided to put 'is_deterministic' and other new
> flags in the 'opts' map field. I've reused existent opts_decode
> mechanism in scope of this patch.

I wrote earlier: it's better to put as many fields as possible to
columns, not options. 

If you disagree, please put forward your arguments first.

I don't mind options, but htey are hard to use, so should be
avoided if possible.


-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32



More information about the Tarantool-patches mailing list