[tarantool-patches] Re: [PATCH v3 7/7] Add merger for tuple streams (Lua part)

[Vladimir Davydov]

On Wed, May 01, 2019 at 12:09:51AM +0300, Konstantin Osipov wrote:
> Vova, did you see my review for merger and key_def patches?

Yes.

> Do you agree with it?

Yes, mostly. We agreed with Alexander that it'd be better to rename
merger_source to merge_source and get rid of merger_context. Regarding
allocating a tuple in key_def.extract_key I think it's okay, because I
doubt that this function will be called often. If somebody requests it,
we can add a buffer parameter to store an extracted key as raw msgpack,
similar to how net_box.select handles it.