[tarantool-patches] Re: [PATCH 4/8] Removes unused functions and macros.

Stanislav Zudin szudin at tarantool.org
Wed May 29 17:01:55 MSK 2019



On 19.05.2019 18:16, n.pettik wrote:
> 
>>
>> diff --git a/extra/mkkeywordhash.c b/extra/mkkeywordhash.c
>> index 2ad74eddc..ba4932b49 100644
>> --- a/extra/mkkeywordhash.c
>> +++ b/extra/mkkeywordhash.c
>> @@ -60,11 +60,7 @@ struct Keyword {
>> #else
>> #  define AUTOINCR   0x00000010
>> #endif
>> -#ifdef SQL_OMIT_CAST
>> -#  define CAST       0
>> -#else
>> #  define CAST       0x00000020
>> -#endif
>> #ifdef SQL_OMIT_COMPOUND_SELECT
>> #  define COMPOUND   0
>> #else
>> @@ -85,11 +81,7 @@ struct Keyword {
>> #define SUBQUERY     0x00001000
>> #  define TRIGGER    0x00002000
>> #  define VIEW       0x00008000
>> -#ifdef SQL_OMIT_CTE
>> -#  define CTE        0
>> -#else
>> #  define CTE        0x00040000
>> -#endif
>> #  define RESERVED   0x00000001
> 
> What about other if-def macros used in mkkeywordhash.c?
> SQL_OMIT_AUTOINCREMENT - we always build with autoincement
> SQL_OMIT_CONFLICT_CLAUSE - we always build with conflict clauses
> SQL_OMIT_PRAGMA - pragmas are always enabled
> 

Thanks, fixed.




More information about the Tarantool-patches mailing list