[tarantool-patches] Re: [PATCH v1 1/1] sql: replace schema_find_id() by box_space_id_by_name()

[n.pettik]

> On 7 May 2019, at 19:41, Konstantin Osipov <kostja at tarantool.org> wrote:
> 
> * n.pettik <korablev at tarantool.org> [19/05/07 19:21]:
>> 
>>> +-- Ensure that the CREATE TRIGGER statement cannot be executed if
>>> +-- the user does not have enough rights. In this case, the user
>>> +-- does not have rights to read from _space.
>>> +--
>>> +box.execute([[CREATE TRIGGER r1 AFTER INSERT ON t1 FOR EACH ROW BEGIN SELECT 1; END; ]])
>>> +---
>>> +- error: Space 'T1' does not exist
>> 
>> Such error looks a bit confusing IMHO. Could we tell the absence
>> of space from lack of rights?
> 
> It's OK to produce a confusing error message for a user which has
> no access to a space. This message is just fine. We should just be
> consistent and not reveal that the space exists through the error
> message.

Ok, I don’t have any other objections, so patch LGTM.