[PATCH v2] box/memtx: Allow to skip tuple memory from coredump

Cyrill Gorcunov gorcunov at gmail.com
Wed May 15 15:54:41 MSK 2019


On Wed, May 15, 2019 at 03:45:58PM +0300, Vladimir Davydov wrote:
> 
> Please patch all places to use the new API. This better be done in a
> separate patch. Call it "Update small submodule". Then I will squash
> submodule sha update in it once we are done.
> 
> I checked - it turns out that SLAB_DONTDUMP path in madvise_checked is
> executed even if box.cfg.strip_core is false. Looks like flags aren't
> initialized properly somewhere. Please fix.
> 
> Please double-check (manually) that this new option does reduce core
> size. Try setting box.cfg.memtx_memory, writing some data to a space,
> then increasing box.cfg.memtx_memory, writing more, crashing the app,
> and checking that the core size is significantly smaller with strip_core
> set.
> 
> Also, as I mentioned in the comment to the previous patch, we should
> emit a warning in case MADV_DONTDUMP is unavailable while strip_core is
> set. This probably better be done here, in Tarantool, using say_warn.

Thanks for review! Will address.



More information about the Tarantool-patches mailing list