[RFC v2] slab_arena: Enhance slab_arena_create to support madvise hints

Vladimir Davydov vdavydov.dev at gmail.com
Mon May 13 14:21:56 MSK 2019


On Mon, May 13, 2019 at 01:30:32PM +0300, Cyrill Gorcunov wrote:
> > > +check_symbol_exists(MADV_NORMAL sys/mman.h TARANTOOL_SMALL_HAS_MADV_NORMAL)
> > > +check_symbol_exists(MADV_DONTDUMP sys/mman.h TARANTOOL_SMALL_HAS_MADV_DONTDUMP)
> > 
> > Do we really need to check all of that? Is a check for MADV_DONTDUMP not
> > enough?
> 
> Well, strictly speaking we should check each definition we use, because I'm
> not sure if MADV_NORMAL defined on other than linux environments.

Why do we use MADV_NORMAL, anyway? We only need MADV_DONTDUMP or
am I missing something?



More information about the Tarantool-patches mailing list