[tarantool-patches] Re: [PATCH v1 06/21] sql: remove SQL_NOTFOUND error/status code

Konstantin Osipov kostja at tarantool.org
Sat May 25 23:26:03 MSK 2019


* n.pettik <korablev at tarantool.org> [19/05/25 21:58]:
> Taking into consideration assert above, it could
> be replaced with assert(pBuilder->nRecValid == nEq - 1);
> Btw, this function doesn’t seem to be called at all:
> unreachable() assert doesn’t fire. I can assume that it is
> connected with stat tables.
> 

NIkita, could you please be more specific, is it an accept or a
reject? Can review comments be done in their own patches? 

This is a big patch stack and I would like us to stop shuffling it
around. If it does improve things, let it get in please and do the
follow up work separately. Or at least let some of the good
patches in.

-- 
Konstantin Osipov, Moscow, Russia




More information about the Tarantool-patches mailing list