[tarantool-patches] Re: [PATCH 1/1] small: introduce static allocator

Konstantin Osipov kostja at tarantool.org
Sat May 4 00:36:13 MSK 2019


* Vladislav Shpilevoy <v.shpilevoy at tarantool.org> [19/05/04 00:34]:
> > OK to push.
> > 
> > Shouldn't you align the address or provide an aligned alloc along
> > with the basic one?
> 
> I thought about a function like static_aligned_alloc just like we
> have for region, but was not sure if we need it now. There are no
> code uses old tt_static_buf for data needed alignment. I hoped we
> could implement it on demand.
> 
> But if you think we should implement it now, I can do that.
> Should I?

Previously tt_static_buf allocations were always aligned, since
the next alloc would always allocate at position 0 in the buffer.
Now you provide a general purpose alloc more or less, which can
start at any position in the buffer. I would simple ensure that
static_alloc() is intptr_t aligned. We can add an aligned alloc
later.


-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32




More information about the Tarantool-patches mailing list