[tarantool-patches] Re: [PATCH 5/5] vinyl: lookup key in reader thread

Konstantin Osipov kostja at tarantool.org
Wed May 29 21:41:45 MSK 2019


* Vladimir Davydov <vdavydov.dev at gmail.com> [19/05/29 21:03]:
> If a key isn't found in the tuple cache, we fetch it from a run file. In
> this case disk read and page decompression is done by a reader thread,
> however key lookup in the fetched page is still performed by the tx
> thread. Since pages are immutable, this could as well be done by the
> reader thread, which would allow us to save some precious CPU cycles for
> tx.
> 
> Close #4257
> ---

This patch is LGTM. The next logical step is moving vy_page_xrow
and vy_page_stmt calls to the reader thread, but this would be
more messy I guess. I'd guess they also consume quite a bit of CPU,
however.


-- 
Konstantin Osipov, Moscow, Russia




More information about the Tarantool-patches mailing list