[tarantool-patches] Re: [PATCH v1 06/21] sql: remove SQL_NOTFOUND error/status code

[n.pettik]

> On 25 May 2019, at 23:26, Konstantin Osipov <kostja at tarantool.org> wrote:
> 
> * n.pettik <korablev at tarantool.org> [19/05/25 21:58]:
>> Taking into consideration assert above, it could
>> be replaced with assert(pBuilder->nRecValid == nEq - 1);
>> Btw, this function doesn’t seem to be called at all:
>> unreachable() assert doesn’t fire. I can assume that it is
>> connected with stat tables.
>> 
> 
> NIkita, could you please be more specific, is it an accept or a
> reject?

I’d say it is rather accept. This fix touches QP and now I
can’t validate it since statistics functionality is disabled.

> Can review comments be done in their own patches? 

Is it common practice for our work-flow? I mean I see
that as a rule fixe are done and squashed with main
patches before they are pushed.

> This is a big patch stack and I would like us to stop shuffling it
> around. If it does improve things, let it get in please and do the
> follow up work separately. Or at least let some of the good
> patches in.

I don’t mind if those patches which I didn’t comment out
will be pushed separately. There’re not so many concerns
from my side, so I guess whole patch-set will be ready soon.