[tarantool-patches] Re: [PATCH v1 03/21] sql: remove SQL_OK error/status code

[Mergen Imeev]

Thank you for review! Mu answer and diff below.

On Sat, May 25, 2019 at 05:45:12PM +0300, n.pettik wrote:
> I’ve found two mentions of this macro in sqlInt.h:
> in comment for sqlColumnsFromExprList() and
> in comment for sql_analysis_load(). Remove
> them as well.
> 
Fixed.

diff --git a/src/box/sql/sqlInt.h b/src/box/sql/sqlInt.h
index c989664..958960e 100644
--- a/src/box/sql/sqlInt.h
+++ b/src/box/sql/sqlInt.h
@@ -3268,7 +3268,7 @@ sql_space_column_is_in_pk(struct space *space, uint32_t);
  * @param parse Parsing context.
  * @param expr_list  Expr list from which to derive column names.
  * @param space_def Destination space definition.
- * @retval sql_OK on success.
+ * @retval 0 on success.
  * @retval error codef on error.
  */
 int sqlColumnsFromExprList(Parse *parse, ExprList *expr_list,
@@ -4567,7 +4567,7 @@ sql_index_tuple_size(struct space *space, struct index *idx);
  * samples[] arrays.
  *
  * @param db Database handler.
- * @retval sql_OK on success, smth else otherwise.
+ * @retval 0 on success, smth else otherwise.
  */
 int
 sql_analysis_load(struct sql *db);