[tarantool-patches] Re: [PATCH 1/2] schema: add "_vcollation" sysview

[Konstantin Osipov]

* Roman Khabibov <roman.habibov at tarantool.org> [19/05/16 14:27]:

> +local function upgrade_to_2_1_4()
> +    local _collation = box.space._collation
> +    local _index = box.space._index
> +
> +    -- System space format usually is in order "id, owner, name...".
> +    -- The fields "name", "owner" are swapped in "_collation" format,
> +    -- due to the field "owner" was added after the "_collation" creation.
> +    box.space._index:delete{276, 1}

why do you delete the index entry just to rename it? Can't you
update the existing record?

> +static bool
> +	vcollation_filter(struct space *source, struct tuple *tuple)
> +	{
> +		(void) source;
> +		(void) tuple;
> +		return true;
> +	}
> +

The return value and function should have the same indent, please
re-indent.

I don't see where 'PUBLIC' role is granted access to the new
space. How does this work?

-- 
Konstantin Osipov, Moscow, Russia