[RFC v2] slab_arena: Enhance slab_arena_create to support madvise hints

Cyrill Gorcunov gorcunov at gmail.com
Mon May 13 15:02:37 MSK 2019


On Mon, May 13, 2019 at 02:56:43PM +0300, Vladimir Davydov wrote:
> > 
> > Because we need a default value, which would be different
> > from MADV_DONTDUMP. Actually MADV_NORMAL = 0 in linux and
> 
> If SLAB_DONTDUMP isn't set, we don't need to call madvise at all, do we?

We don't, yes.

> 
> > I think we may even live without this member initialized
> 
> If we store SLAB_* flags in slab_arena instead of map_flags + madv_flags
> we won't be facing this problem, will we?

Then I think we will be able to drop it. I'll prepare a patch at
the evening and we find out.



More information about the Tarantool-patches mailing list