[tarantool-patches] Re: [PATCH 0/3] Fix CAST operation

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Mon May 27 23:43:05 MSK 2019


LGTM.

On 21/05/2019 13:34, Nikita Pettik wrote:
> Branch: https://github.com/tarantool/tarantool/tree/np/gh-4229-adjust-cast
> Issue: https://github.com/tarantool/tarantool/issues/4229
> 
> This patch-set allows explicit conversion using CAST operator from REAL
> to BOOLEAN and from string value containing quoted floating point
> literal to INTEGER. Detailed explanation is provided in commit messages
> and in issue description.
> 
> Nikita Pettik (3):
>   sql: remove redundant conversion from OP_AddImm
>   sql: allow CAST operation from REAL to BOOLEAN
>   sql: allow CAST operation from quoted float to int
> 
>  src/box/sql/vdbe.c      |  2 +-
>  src/box/sql/vdbemem.c   | 12 ++++++++---
>  test/sql/types.result   | 54 ++++++++++++++++++++++++++++++++++++++++++++++++-
>  test/sql/types.test.lua | 11 ++++++++++
>  4 files changed, 74 insertions(+), 5 deletions(-)
> 




More information about the Tarantool-patches mailing list