[PATCH v3 2/2] test: move background index build test to engine suite from vinyl

Vladimir Davydov vdavydov.dev at gmail.com
Wed May 29 19:03:02 MSK 2019


On Tue, May 28, 2019 at 06:33:25PM +0300, Serge Petrenko wrote:
> +-- check that index build is aborted in case conflicting tuple is inserted
> +-- error injection makes index build yield after 1 tuple is inserted into
> +-- new index, check that index build is aborted if unique constraint is
> +-- violated, as well as if tuple format doesn't match the new indexes one.
> +box.error.injection.set('ERRINJ_BUILD_INDEX_DELAY', 0.001)

Please use boolean error injection if possible, i.e. loop until it is
cleared. Timeouts are very unreliable in parallel test run.

Also, it looks like this test shouldn'be run in the release mode.
Worth adding engine/errinj_ddl.test.lua?

Also, vinyl has similar tests too, see vinyl/errinj_ddl.test.lua.
It would be great if you could unify them using this new error
injection you introduce.



More information about the Tarantool-patches mailing list