[tarantool-patches] Re: [PATCH v4 1/4] schema: add new system space for CHECK constraints

[Kirill Shcherbatov]

> Somewhy you trimmed the context, but here it is again:
> 
>     "we create a list of a new ck constraints objects"
> 
> You wrote "a new ck constraints objects". Firstly, "a objects"
> is incorrect. Secondly, if you want to describe an object as
> purposed to something, you do not need plural. It should be
> 
>     "we create a list of new ck constraint objects"
> 
> "constraints" -> "constraint", it is like an adjective here.
> "a objects" -> "objects". You can't use 'a' with plural.
Fixed.

>>> 8. We already have ADD CONSTRAINT. It works for FK, UNIQUE, PK. The
>>> problem is that we can't call it on a non-empty space.
>> https://github.com/tarantool/tarantool/issues/4243
> 
> My comment was rather about incorrect comment - "ADD CONSTRAINT"
> is already implemented, but here you state, that it is not so. The
> comment is still incorrect.
Ok, now it is

		/*
		 * FIXME: Ck constraint creation on non-empty
		 * space is not implemented yet.
		 */