[tarantool-patches] [PATCH v2 1/5] lib: introduce json_path_is_multikey helper

Konstantin Osipov kostja.osipov at gmail.com
Tue Mar 19 18:43:24 MSK 2019


* Kirill Shcherbatov <kshcherbatov at tarantool.org> [19/03/19 16:15]:
> Introduced a new json_path_is_multikey routine to test if
> JSON path contains array index placeholder JSON_TOKEN_ANY and
> return multikey_path_len if so.
> +    ok 9 - test json_path_is_multikey: non-multikey path
> +    ok 10 - test json_path_is_multikey: multikey path
> +    ok 11 - test json_path_is_multikey: multikey path 8/8

This coverage is insufficient. You should at least test an empty
path, a path with * in the beginning, middle and end.

-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov



More information about the Tarantool-patches mailing list