[tarantool-patches] Re: [PATCH v3 2/9] sql: save SQL parser errors in diag_set()

[Konstantin Osipov]

* imeevma at tarantool.org <imeevma at tarantool.org> [19/03/03 23:25]:
> +	/*186 */_(ER_SQL_PARSER_GENERIC,	"%s") \

Simply ER_SQL_PARSER
>  
>  /*
>   * !IMPORTANT! Please follow instructions at start of the file
> diff --git a/src/box/sql/build.c b/src/box/sql/build.c
> index f112c9f..deb5b89 100644
> --- a/src/box/sql/build.c
> +++ b/src/box/sql/build.c
> @@ -194,7 +194,8 @@ sql_finish_coding(struct Parse *parse_context)
>  		sqlVdbeMakeReady(v, parse_context);
>  		parse_context->rc = SQL_DONE;
>  	} else {
> -		parse_context->rc = SQL_ERROR;
> +		if (parse_context->rc != SQL_TARANTOOL_ERROR)
> +			parse_context->rc = SQL_ERROR;

Shouldn't this become bool abort?


-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov