[tarantool-patches] Re: [PATCH v1 1/1] box: fix custom delimiter for telnet connection

Kirill Yukhin kyukhin at tarantool.org
Thu Mar 7 13:16:47 MSK 2019


Hello,

On 21 Feb 10:34, Kirill Shcherbatov wrote:
> Because test-run uses a console connection to run tests, the
> actual string delimiter was the user-specified delimiter
> delim + "\n".
> Since telnet sends \r\n on line break, the updated expression
> delim + "\n"could not be found in a sequence data+delim+"\r\n",
> so delimiter feature did not work at all.
> Added delim + "\r" check along with delim + "\n", that solves the
> described problem and does not violate backward compatibility.
> 
> Closes #2027
> 
> https://github.com/tarantool/tarantool/tree/kshch/gh-2027-telnet-alternative-delimiter
> https://github.com/tarantool/tarantool/issues/2027

I've committed your patch into 2.1 branch.

--
Regards, Kirill Yukhin




More information about the Tarantool-patches mailing list